Skip to content

Conversation

wangl-cc
Copy link
Contributor

@wangl-cc wangl-cc commented Jun 10, 2022

Fix #308, #309

@wangl-cc wangl-cc changed the title Fix to_index for CartesianIndices #308 and first for LazyAxis #309 Fix to_index for CartesianIndices and first for LazyAxis Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #310 (6af3483) into master (de94815) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files           9        9           
  Lines        1398     1398           
=======================================
  Hits         1274     1274           
  Misses        124      124           
Impacted Files Coverage Δ
src/axes.jl 92.05% <0.00%> (ø)
src/indexing.jl 86.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de94815...6af3483. Read the comment docs.

Copy link
Member

@Tokazama Tokazama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll try to get some more exhaustive tests for LazyAxis in soon so we can ensure this sort of thing doesn't happen anymore.

@Tokazama Tokazama merged commit c0046f8 into JuliaArrays:master Jun 10, 2022
@wangl-cc wangl-cc deleted the fix/getindex branch June 11, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect getindex for CartesianIndices
2 participants