Skip to content

Conversation

chriselrod
Copy link
Collaborator

No description provided.

@chriselrod chriselrod requested a review from Tokazama June 6, 2022 20:18
@chriselrod chriselrod changed the title add missing defs add missing OffsetArray defs Jun 6, 2022
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #303 (d9e7109) into master (5569c5e) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   91.26%   90.93%   -0.33%     
==========================================
  Files           9        9              
  Lines        1396     1401       +5     
==========================================
  Hits         1274     1274              
- Misses        122      127       +5     
Impacted Files Coverage Δ
src/stridelayout.jl 89.15% <0.00%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5569c5e...d9e7109. Read the comment docs.

@chriselrod chriselrod force-pushed the offsetarraymissingdefs branch from 71becb5 to d9e7109 Compare June 6, 2022 20:24
Copy link
Member

@Tokazama Tokazama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not sure why ArrayInterfaceOffsetArrays can't find contiguous_axis in the tests though.

@chriselrod
Copy link
Collaborator Author

LGTM. I'm not sure why ArrayInterfaceOffsetArrays can't find contiguous_axis in the tests though.

There was typo/misspelling.

@Tokazama Tokazama merged commit 57c81ad into master Jun 7, 2022
@Tokazama Tokazama deleted the offsetarraymissingdefs branch June 7, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants