feat: add safe version of some of TypeScript's private type guards #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #50 +/- ##
==========================================
- Coverage 14.50% 11.22% -3.29%
==========================================
Files 15 16 +1
Lines 393 508 +115
Branches 160 227 +67
==========================================
Hits 57 57
- Misses 333 448 +115
Partials 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RebeccaStevens
changed the title
5 tasks
|
Marking as blocked on microsoft/TypeScript#52727 - I'd like to see what the TS team is open to, in case we don't need to re-implement these |
JoshuaKGoldberg
added
the
status: blocked
3 tasks
|
Closing for now as a lot of these are coming in TS 5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Based off #49
Recreates the logic of bunch of type guards defined in TypeScript's private API.
The logic slightly differs from TypeScript's in-order to make the function "safe".
For example: TypeScript's
isExpressionis designed to work with partially emitted node while this version requires fully emitted nodes.