Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 4, 2025

PR Checklist

Overview

Remove the explicit setting of tsconfigRootDir. Since the corresponding PR in typescript-eslint is now in review, I think it's "soon enough" to make this change in userland. Setting it explicitly is a safety precaution for edge cases.

🎁

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (ae26c93) to head (72a7aa0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2245      +/-   ##
==========================================
- Coverage   99.80%   99.80%   -0.01%     
==========================================
  Files         136      136              
  Lines        6111     6110       -1     
  Branches      509      509              
==========================================
- Hits         6099     6098       -1     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg merged commit bef2d36 into main Jul 4, 2025
12 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the implicit-tsconfigrootdir branch July 4, 2025 14:01
@github-actions
Copy link

github-actions bot commented Jul 4, 2025

🎉 This is included in version v2.46.3 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Lint complaint on new repo with --preset everything: n/no-unsupported-features/node-builtins

2 participants