Remove unneeded swift_name attributes from Objective-C headers #5518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please feel free to comment on my kotlin style. It is not my primary language by a long shot. |
| val privateAttribute: String? = property.getSwiftPrivateAttribute() | ||
| if (privateAttribute != null) { | ||
| declarationAttributes.add(privateAttribute) | ||
| } else if (propertyName.objCName != propertyName.swiftName) { |
There was a problem hiding this comment.
Doesn't this optimization lead to an issue like this: JetBrains/kotlin-native#2571?
There was a problem hiding this comment.
Ack. Was unaware of that case. Updated with fix.
dmaclach
force-pushed
the
unneeded_swiftnames
branch
3 times, most recently
from
56f6ce2 to
c04ac24
Compare
|
Ignore for a moment. Fixing the AA cases. |
Partial fix for KT-81447 Native: Objective-C: Excessive 'swift_name' attributes being generated Removes swift_name attribute from declarations that would already have that swift name. Initially focusing on properties and and simple methods that have no parameters. The excessive use of swift_attributes creates large headers, and even larger pcm files generated from those headers.
dmaclach
force-pushed
the
unneeded_swiftnames
branch
from
c04ac24 to
08eccc7
Compare
|
AA cases all fixed. It's a big change, but not sure how I could really break it up unless you want properties/methods split out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for
KT-81447 Native: Objective-C: Excessive 'swift_name' attributes being generated
Removes swift_name attribute from declarations that would already have that swift name. Initially focusing on properties and and simple methods that have no parameters.
The excessive use of swift_attributes creates large headers, and even larger pcm files generated from those headers.