Switch macOS native certs to retrieve from JDK (maintain root compat with <23) #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Potentially limited benefit in maintaining the compatibility, JetBrains has a forked JDK and the changes can just be backported down to the supported lines to resolve this for the JetBrains IDEs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #6 which maintains compatibility with Java <23 for predefined roots
I tried to implement #3 in #5 but I couldn't make the JNA bindings work, I'm not sure if its JNA limitations to do with constants required or if I was doing something wrong but I was hitting a solid brick wall which gave me no clues on what was wrong.
Instead I've ported this to use the Apple truststores provided by the JVM which was trivial to do.
Closes #5
This won't
fix#3 as its now dependent on the JVM.But it will be fixed by openjdk/jdk#22911 which looks like it should get merged soon-ish and then hopefully it can be backported.