This repository was archived by the owner on Jan 14, 2019. It is now read-only.
refactor: improve type checking in parser #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
force-pushed
the
types-in-convert
branch
from
4ad6480 to
c7af360
Compare
armano2
changed the title
armano2
force-pushed
the
types-in-convert
branch
2 times, most recently
from
7736feb to
c7af360
Compare
|
@JamesHenry am i going in correct direction? i started also adding type checking for AST from eslint: |
|
I only have some nits with this, such as the camelCase file name tsNodes and the exported type AllTSNodes feels less intuitive than the singular I'm travelling this week as I mentioned, so only have very limited chance to look at these PRs, and that's why I prioritized the low risk chores/refactors Thanks again for your support 👍 |
armano2
force-pushed
the
types-in-convert
branch
from
25a30d5 to
b5bdccc
Compare
armano2
force-pushed
the
types-in-convert
branch
from
b5bdccc to
5dce37c
Compare
|
:> |
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper typing to convert.ts
this PR contains logical change (it's not affecting resulted ast)
while doing this i found few issues with current implementation and i marked with
// TODOfor feature investigation: