This repository was archived by the owner on Apr 19, 2018. It is now read-only.
Groovydoc + Non-android projects + SdkResolverTest fix + com.jakewharton.sdkmanager plugin alias #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Util.* + added javadocs for em
…on't require android closure. + Groovydoc
|
Hmmh... had the chance to look at this PR? @JakeWharton |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request accomplishes a few things:
src/main, they can be improved, but I think it's a good balance.SdkResolverTestthat caused a few tests to fail if on a Windows OS due to\\vs\\\\.SdkManagerActionas a standalone component that could potentially be used in a task, or somewhere else...SdkManagerPluginsimply constructs aSdkManagerActionand executes it.androidclosure.com.jakewharton.sdkmanageras a plugin alias as should be done for newer gradle projects.Breaking changes? None.
Recommendation for versioning: minor version increment, this adds features and isn't just bugfix.