-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Walkthrough additions #13745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Walkthrough additions #13745
Conversation
jabgui/src/main/java/org/jabref/gui/walkthrough/WalkthroughAction.java
Outdated
Show resolved
Hide resolved
// The callee must guarantee the node to be attached is at least visible | ||
// in the scene to begin with. If such exception is thrown, it indicates | ||
// a bug in the caller side. Consider adjusting WalkthroughResolver. | ||
throw new IllegalStateException("Failed to attach the node."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception is used for control flow rather than an exceptional state. The code should handle the case where node cannot be positioned as a normal flow path instead of throwing an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exception is intentional to catch programming error. A failed to detach state leads to undefined behavior—whether we should darken the entire window, or to highlight nothing, is questionable—but a sure way to lead to errors in subsequent calls to the Spotlight object.
Thanks for quick action! |
For the submodules thing, see https://devdocs.jabref.org/code-howtos/faq.html#submodules |
You just need to run the openrewrite task, then it will be good |
Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of |
jabgui/src/main/java/org/jabref/gui/walkthrough/declarative/NodeResolver.java
Show resolved
Hide resolved
* upstream/main: (32 commits) Fix path (#13769) Mode aware consistency check (#13584) Refine JBang check (#13765) Add Language Server to the UI and add the integrity/consistency check (#13697) Fix/remove comment code (#13763) New Crowdin updates (#13760) Bump org.openrewrite.rewrite from 7.14.0 to 7.14.1 (#13757) Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13756) Bump dev.langchain4j:langchain4j-bom from 1.2.0 to 1.3.0 in /versions (#13755) Bump jablib/src/main/resources/csl-locales from `fa56de1` to `e29c453` (#13754) Bump com.autonomousapps:dependency-analysis-gradle-plugin (#13753) Bump org.mockito:mockito-core from 5.18.0 to 5.19.0 in /versions (#13752) Bump actions/upload-pages-artifact from 3 to 4 (#13751) Migrate fetchers to Search.g4 ANTLR parser. (#13691) [Junie]: fix: resolve IllegalArgumentException for non-absolute URIs (#13669) Add auto-renaming of linked files on entry data change (#13295) Walkthrough additions (#13745) Switch from zulu to corretto (#13749) New Crowdin updates (#13747) Fix copy to (#13741) ...
Closes Yubo-Cao#6
This PR fixes the following error:
Steps to test
a. Click on other group in the entry tab during the walkthrough without leading to error
b. Close the add group dialog in the middle without leading to error
Mandatory checks
CHANGELOG.md
in a way that is understandable for the average user (if change is visible to the user)