Skip to content

fix git modules requires and uses #13696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

fix git modules requires and uses #13696

merged 1 commit into from
Aug 14, 2025
+5 −1

Conversation

@Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Aug 14, 2025 •
edited
Loading

Closes #13695

Steps to test

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [.] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@trag-bot
Copy link

trag-bot bot commented Aug 14, 2025

@trag-bot didn't find any issues in the code! ✅✨

@Siedlerchr Siedlerchr mentioned this pull request Aug 14, 2025
Closed
2 tasks
@koppor koppor added this pull request to the merge queue Aug 14, 2025
Merged via the queue into main with commit 6fcfe99 Aug 14, 2025
2 checks passed
@koppor koppor deleted the fixgit branch August 14, 2025 19:10
@chrisdenman
Copy link
Contributor

This one's resolved:

2025-08-14 16:57:57 [ForkJoinPool-1-worker-1] org.eclipse.jgit.lib.Signers.loadSigners()
ERROR: org.eclipse.jgit.lib.SignerFactory: module org.eclipse.jgit does not declare `uses`: java.util.ServiceConfigurationError: org.eclipse.jgit.lib.SignerFactory: module org.eclipse.jgit does not declare `uses`

This one is still happening:

org.eclipse.jgit.api.errors.UnsupportedSigningFormatException: No signer for ssh signatures. Use another signature type for git config gpg.format, or do not sign.

I'll see if I can get more information for you.

Siedlerchr added a commit that referenced this pull request Aug 15, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into addNoopReader
7435ec7 
* upstream/main:
  Added static (stream & preferences) constructors to BibDatabaseContext (#13694)
  New Crowdin updates (#13698)
  fix git modules requires and uses (#13696)
  Focus "Specify Bib(La)TeX" when Bib(La)TeX is in clipboard (#13633)
Siedlerchr added a commit that referenced this pull request Aug 21, 2025
@Siedlerchr
Merge remote-tracking branch 'upstream/main'
9bee24f 
* upstream/main:
  New translations jabref_en.properties (Italian) (#13725)
  Minor code style updates (#13722)
  Fix: Make FileUtil.relativize symlink-aware (#13553)
  New Crowdin updates (#13720)
  Bump org.glassfish.jersey.core:jersey-server in /versions (#13714)
  Enable UseObjectNotifyAll (#13718)
  Bump com.dlsc.gemsfx:gemsfx from 3.3.5 to 3.4.2 in /versions (#13717)
  Update on-issue-comment.yml
  Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.12.1 to 3.13.0 (#13716)
  Bump org.openrewrite.rewrite from 7.12.1 to 7.14.0 (#13715)
  Bump org.glassfish.jersey.inject:jersey-hk2 in /versions (#13713)
  feat(git): add “Share to GitHub” flow (#13677)
  Bump jablib/src/main/resources/csl-styles from `292aec3` to `1194364` (#13712)
  Bump jablib/src/main/abbrv.jabref.org from `cfe719f` to `a97f9c6` (#13711)
  Bump jablib/src/main/resources/csl-locales from `e2de1e3` to `fa56de1` (#13710)
  Add noop Git Config System Reader to prevent usage of real world stuff into jgit (#13703)
  Added static (stream & preferences) constructors to BibDatabaseContext (#13694)
  New Crowdin updates (#13698)
  fix git modules requires and uses (#13696)
  Focus "Specify Bib(La)TeX" when Bib(La)TeX is in clipboard (#13633)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests fail when git SSH commit signing is enabled.

4 participants

@Siedlerchr @chrisdenman @koppor