Add tab key navigation for empty text areas to move to the next field #12547
Conversation
# Conflicts: # src/main/java/org/jabref/gui/fieldeditors/EditorTextArea.java
CHANGELOG.md
Outdated
| - We added a new behavior for the Tab key in empty text areas, ensuring that pressing Tab moves the focus to the next field instead of inserting a tab character. [#11938](https://github.com/JabRef/jabref/issues/11938) | ||
|
|
||
| ### Added | ||
|
|
There was a problem hiding this comment.
Please fix the changelog, conform to the way other entries are added. There happens to be an extra heading here.
Also refine the line as "Pressing Tab in empty text areas now moves..."
There was a problem hiding this comment.
@subhramit From what I understand, I need to add this line to the last 'Added' section and refine it so that it starts with "Pressing Tab..." and continues until the end of the line. Please let me know if this is correct.
CHANGELOG.md
Outdated
| - We added a new CLI that supports txt, csv, and console-based output for consistency in BibTeX entries. [#11984](https://github.com/JabRef/jabref/issues/11984) | ||
| - We added a new dialog for bibliography consistency check. [#11950](https://github.com/JabRef/jabref/issues/11950) | ||
| - We added a feature for copying entries to libraries, available via the context menu, with an option to include cross-references. [#12374](https://github.com/JabRef/jabref/pull/12374) | ||
| - Pressing Tab moves the focus to the next field instead of inserting a tab character. [#11938](https://github.com/JabRef/jabref/issues/11938) |
There was a problem hiding this comment.
This became vague - think - does it convey the change properly?
In my previous comment, I told to start with "Pressing Tab in empty text areas fields now moves..."
There was a problem hiding this comment.
Okay, I will change it to "Pressing Tab in empty text areas of the entry editor now moves the focus to the next field instead of inserting a tab character. #11938", is this ok or need more refining?
There was a problem hiding this comment.
"fields", not "areas". The rest is fine.
There was a problem hiding this comment.
Is the word "Fields" correct? The text fields already work properly, and this PR specifically solves the issue with text areas.
There was a problem hiding this comment.
Are you referring to JavaFX textfields vs textareas? A user won't be aware of that. He will just see them as fields. The issue states the same.
Do clarify if you meant something else?
There was a problem hiding this comment.
"field" refers to Bibtex-Field, entry editor field, not the technical term in this context/changelog
| pasteActionHandler.run(); | ||
| } | ||
|
|
||
| // Custom event handler for Tab key presses. |
| - For the Citation key generator patterns, we reverted how `[authorsAlpha]` would behave to the original pattern and renamed the LNI-based pattern introduced in V6.0-alpha to `[authorsAlphaLNI]`. [#12499](https://github.com/JabRef/jabref/pull/12499) | ||
| - We keep the list of recent files if one files could not be found. [#12517](https://github.com/JabRef/jabref/pull/12517) | ||
| - During the import process, the labels indicating individual paragraphs within an abstract returned by PubMed/Medline XML are preserved. [#12527](https://github.com/JabRef/jabref/issues/12527) | ||
| - Pressing Tab in empty text fields of the entry editor now moves the focus to the next field instead of inserting a tab character. [#11938](https://github.com/JabRef/jabref/issues/11938) |
There was a problem hiding this comment.
Follow-up: Replace Tab by <kbd>Tab</kbd>
4 participants
Closes #11938
This PR adds a behavior for navigation among text areas using a tab button instead of inserting a tab character into the text area.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)Before Tab
After Tab
After Shift + Tab