Fix main table sorting #12371
Merged
Fix main table sorting #12371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calixtus
approved these changes
Jan 9, 2025
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
added a commit
to ar-rana/jabref
that referenced
this pull request
Jan 13, 2025
* upstream/main: (29 commits) Bump org.glassfish.jersey.containers:jersey-container-grizzly2-http (JabRef#12384) Bump src/main/resources/csl-styles from `080516e` to `6bae16d` (JabRef#12387) Bump src/main/resources/csl-locales from `96d704d` to `9914965` (JabRef#12386) Bump buildres/abbrv.jabref.org from `93a2cad` to `e74e6eb` (JabRef#12385) Bump org.openrewrite.rewrite from 6.29.3 to 7.0.0 (JabRef#12383) Bump org.glassfish.jersey.core:jersey-server from 3.1.9 to 3.1.10 (JabRef#12381) Bump org.glassfish.jersey.test-framework.providers:jersey-test-framework-provider-grizzly2 (JabRef#12380) fix linux build not updated Refactor the isUnwantedText (JabRef#12369) Searching for entries with empty field (JabRef#12376) Downgrade Ubuntu (JabRef#12375) Downgrade Ubuntu Fix main table sorting (JabRef#12371) fix bib and pdf name (JabRef#12366) use v4 instead of master Update abbrv.jabref.org (JabRef#12365) Bump buildres/abbrv.jabref.org from `78e1b08` to `c202741` (JabRef#12363) Bump org.beryx.jlink from 3.1.0-rc-1 to 3.1.1 (JabRef#12362) Bump tech.units:indriya from 2.2.1 to 2.2.2 (JabRef#12361) Bump com.dlsc.gemsfx:gemsfx from 2.80.0 to 2.81.0 (JabRef#12360) ... # Conflicts: # buildres/abbrv.jabref.org # src/main/resources/csl-styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11510
Fixed issues with main table sorting:
These issues due to a JavaFX bug: https://bugs.openjdk.org/browse/JDK-8301761 (The sorting of the
SortedListcan become invalid).Attempted to fix the issue in the jfx, but the PR was closed: openjdk/jfx#1519.
This workaround implements a similar solution to the one proposed in the closed PR (considering the insertion index of the entries while comparing them).
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)