Skip to content

Conversation

@Nicholas-An
Copy link

Closes #11898
Removed a chunk of code that was overriding the background colour of bib entires when dragging and dropping a file. Initially caused by changes implemented when resolving #11579.

Screenshot 2024-10-15 at 8 04 10 pm Screenshot 2024-10-15 at 8 02 29 pm

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr requested a review from LoayGhreeb October 15, 2024 09:23
@Siedlerchr
Copy link
Member

I am not sure that removing all the colors is really a good idea, they were implemented for the different searching options ("floating mode") with groups and without groups

@calixtus
Copy link
Member

Yes, this would remove the visual distinction between matching groups in floating search mode.
Please reimplement the matching/non-matching colors. Highlighting must respect them. Maybe @loay can help here?

@Nicholas-An
Copy link
Author

Ah that makes sense! I thought for some reason the deleted section was redundant, I'll rework it to work around the matching groups in floating search mode. Thanks for the feedback!

@Siedlerchr Siedlerchr added the status: changes-required Pull requests that are not yet complete label Oct 16, 2024
@Siedlerchr
Copy link
Member

What is the status here?

@koppor
Copy link
Member

koppor commented Oct 31, 2024

Link to PRs "fixing" the colors: #11591

@loay
Copy link

loay commented Oct 31, 2024

Yes, this would remove the visual distinction between matching groups in floating search mode. Please reimplement the matching/non-matching colors. Highlighting must respect them. Maybe @loay can help here?

I think you mentioned the wrong loay here :)

@calixtus
Copy link
Member

Ooops, sorry. 🤣

@koppor
Copy link
Member

koppor commented Dec 9, 2024

Closing this issue due to inactivity 💤

@koppor koppor closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: changes-required Pull requests that are not yet complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change entry color when dragging files (highlight row again)

5 participants