Skip to content

Conversation

@Emmy-D
Copy link

@Emmy-D Emmy-D commented Mar 30, 2023

Additions to the code include:

  • the ability to ingest lunar data (before, the radius was hard coded and assumed to be Mars)
  • localization functions for LROC based on the non-map projected HiRISE 4 corner localization functions (there are some different conventions but they are similar)
  • unit tests for LROC browse and non-browse localizers using the 4-corner and central lat/lon values in the metadata

@garydoranjr garydoranjr changed the base branch from master to develop June 1, 2023 00:50
Copy link
Contributor

@garydoranjr garydoranjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Emmy-D Thanks a lot for making these changes, looks good! I made a bunch of minor comments.

One bigger question is about which additional files to include with this software. I think we should probably exclude any LROC-specific scripts that were used for the LROCnet project, since those will not be needed by most folks who download and install this software. Likewise, it might be good to exclude the inputs and inputs_mini directories (and corresponding examples in the README), since these seem specific to the LROCnet project or to the MLIA/JPL computing environments. I think these would be better to include in a separate repository that hosts the code for that project. Let me know what you think and whether you want to discuss at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants