Skip to content

Conversation

geo2a
Copy link
Contributor

@geo2a geo2a commented Jul 8, 2025

Closes tweag/cardano-peras#61

This PR contains a micro benchmark for Peras chain weight calculation as implemented by the by the Ouroboros.Consensus.Storage.PerasCertDB.API.boostedWeightForFragment function.

Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, some comments on increasing "realism"

@geo2a geo2a force-pushed the geo2a/benchmarks branch 2 times, most recently from 6c69b19 to 5465a5e Compare July 11, 2025 07:28
@geo2a geo2a force-pushed the geo2a/benchmarks branch from 5465a5e to a7bcfd4 Compare July 11, 2025 11:31
@amesgen amesgen merged commit 0d3e7e9 into peras-staging Jul 11, 2025
9 of 13 checks passed
@amesgen amesgen deleted the geo2a/benchmarks branch July 11, 2025 12:39
Comment on lines +60 to +61
getEveryN (fragmentLenghtSamplingRate benchmarkParams) $
take (fromIntegral $ fragmentMaxLenght benchmarkParams) $
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not to be too annoying leaving a review comment after the PR's been merged, but would you be able to fix the typo'd length in both fragmentLenghtSamplingRate and fragmentMaxLenght?

github-merge-queue bot pushed a commit that referenced this pull request Jul 16, 2025
This PR moves the `Test.Ouroboros.Storage.TestBlock` module form
`storage-test` to `unstable-consensus-testlib` so that it could be used
in a wider context. Specifically, I'd like to use it for Peras-related
benchmarking in
#1583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants