-
Notifications
You must be signed in to change notification settings - Fork 32
Peras chain weight microbenchmark #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, some comments on increasing "realism"
6c69b19
to
5465a5e
Compare
getEveryN (fragmentLenghtSamplingRate benchmarkParams) $ | ||
take (fromIntegral $ fragmentMaxLenght benchmarkParams) $ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not to be too annoying leaving a review comment after the PR's been merged, but would you be able to fix the typo'd length
in both fragmentLenghtSamplingRate
and fragmentMaxLenght
?
This PR moves the `Test.Ouroboros.Storage.TestBlock` module form `storage-test` to `unstable-consensus-testlib` so that it could be used in a wider context. Specifically, I'd like to use it for Peras-related benchmarking in #1583
Closes tweag/cardano-peras#61
This PR contains a micro benchmark for Peras chain weight calculation as implemented by the by the
Ouroboros.Consensus.Storage.PerasCertDB.API.boostedWeightForFragment
function.