-
Notifications
You must be signed in to change notification settings - Fork 739
OCI symlink and path updates #6110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfd9ecd
to
e7dc17d
Compare
0fc8a5e
to
aa51649
Compare
disassembler
approved these changes
Feb 12, 2025
4540898
to
77968ff
Compare
77968ff
to
9acaffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes improvements to the cardano-node and cardano-submit-api oci images in the following ways:
New Features
Additional network configs in the node image:
/opt/cardano/config/mainnet-{config,topology}.json
/opt/cardano/config/$NETWORK/
with the tree of configuration for an example NETWORK looking like:/opt/cardano/config/mainnet-{config,topology}.json
config files are symlinked to this new config structure for backwards compatibility.A new merge mode in the node image:
nix/docker/README.md
for details.Documentation
nix/docker/README.md
where most would expect to find them.Inconsistencies Addressed
/opt/cardano/{data,ipc,logs}
symlinked to root/{data,ipc,logs}
/{data,ipc,logs}
usable with all modes/data/db
/ipc
and the node socket file path to/ipc/node.socket
/node-ipc
now symlinked to/ipc
for backwards compatibility.Breaking Changes
-e ENVNAME=<...>
. These breaking changes are:Checklist