Skip to content

Conversation

@Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Mar 26, 2024

Description

Resolves #3682

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky
Copy link
Contributor Author

@nfrisby if I understand correctly, this should not be merged until some of the concerns you mention here are addressed, right? Especially the obsolete node checks part as this PR would remove the protocol version check from chainChecks (which would be okay I guess if we decide to ban intra-era hard forks at some point).

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lucsanszky Feedback from consensus folks:

The idea would be for the ledger PR to remove maxMajorPV from Globals, but not from chainChecks

The only reason why you had to remove Version from chainChecks is because we used maxMajorPV from Globals for chainChecks in shelley test.

@Lucsanszky Lucsanszky force-pushed the lucsanszky/remove-maxmajorpv branch 7 times, most recently from b9957d2 to a1ae142 Compare August 19, 2024 22:20
@Lucsanszky Lucsanszky marked this pull request as ready for review August 19, 2024 22:37
@Lucsanszky Lucsanszky force-pushed the lucsanszky/remove-maxmajorpv branch 4 times, most recently from 4e83e2e to 9990121 Compare August 29, 2024 14:09
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than cardano-ledger-core version this PR is good to go.

@Lucsanszky Lucsanszky force-pushed the lucsanszky/remove-maxmajorpv branch from 9990121 to ac88821 Compare August 29, 2024 18:05
@lehins lehins enabled auto-merge August 29, 2024 18:12
@lehins lehins force-pushed the lucsanszky/remove-maxmajorpv branch from ac88821 to 0141740 Compare August 29, 2024 18:12
@lehins lehins merged commit 41d3220 into master Aug 30, 2024
@lehins lehins deleted the lucsanszky/remove-maxmajorpv branch August 30, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The maxMajorPV field of Globals is unused

2 participants