Skip to content

Conversation

@newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Apr 2, 2025

Changelog

- description: |
    Source import of the `vary` package
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This change is temporary until the vary package supports ghc-8.10 after the upstream PR is merged and/or ghc-8.10 support is no longer required.

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hlint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@newhoggy newhoggy force-pushed the newhoggy/source-import-of-vary-package branch from b19a6ad to 63ea9fc Compare April 2, 2025 12:32
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. There are some HLint warnings and GHC errors though.

@newhoggy newhoggy force-pushed the newhoggy/source-import-of-vary-package branch from 63ea9fc to 7152dd6 Compare April 2, 2025 12:51
@newhoggy newhoggy requested a review from carbolymer April 2, 2025 12:59
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Small thing, let's mention in the context in the PR description that this change is temporary, and we should revert it and use vary package eventually after the upstream PR is merged and/or 8.10 support is no longer required

@newhoggy newhoggy force-pushed the newhoggy/source-import-of-vary-package branch from 7152dd6 to e9cb1ef Compare April 2, 2025 22:12
@newhoggy newhoggy added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 3, 2025
@carbolymer carbolymer added this pull request to the merge queue Apr 3, 2025
Merged via the queue into master with commit 113f884 Apr 3, 2025
25 checks passed
@carbolymer carbolymer deleted the newhoggy/source-import-of-vary-package branch April 3, 2025 09:22
@newhoggy
Copy link
Contributor Author

Addresses #566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants