Skip to content

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Mar 28, 2025

Changelog

- description: |
    Delete top-level `shelley` command group and delete associated tests
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Tests that no longer work are deleted.

How to trust this PR

Golden files updated.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/delete-top-level-shelley-command-group branch from 684d72e to 56520fa Compare March 28, 2025 13:11
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment that needs to be addressed.

@newhoggy newhoggy added this pull request to the merge queue Mar 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 28, 2025
@newhoggy newhoggy added this pull request to the merge queue Mar 29, 2025
Merged via the queue into master with commit a142e98 Mar 29, 2025
27 checks passed
@newhoggy newhoggy deleted the newhoggy/delete-top-level-shelley-command-group branch March 29, 2025 01:41
@carbolymer
Copy link
Contributor

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants