Visual referee messages sending with RNG handsignal #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkbkaiser
reviewed
Jul 8, 2023
crates/control/src/referee.rs
Outdated
|
|
||
| pub fn cycle(&mut self, context: CycleContext<impl Interface>) -> Result<()> { | ||
| if context.filtered_whistle.started_this_cycle { | ||
| if self.first { |
There was a problem hiding this comment.
This bool is probably not necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Changes
When a whistle is heard, it will send a random u8 to the game controller with the correct protocol by using bifrost.
ToDo / Known Issues
Errors are not handled correctly. Should not be merged into main but will suffice for the robocup branch.
If this is a WIP describe which problems are to be fixed.
Handle the possible errors of sending a message by using options.
Ideas for Next Iterations (Not This PR)
Implement the model with CompiledNN
How to Test
Check gamecontroller logs.
Describe how to test your changes. (For the reviewer)