A more consistent kernel launch parameter syntax #888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chudur-budur
requested review from
mingjie-intel and
diptorupd
as code owners
chudur-budur
force-pushed
the
github-871
branch
from
8373c3b to
d596f53
Compare
…nel_interface.utils.Ranges instead. Fix in docstrings
chudur-budur
force-pushed
the
github-871
branch
from
d596f53 to
e66c0fc
Compare
diptorupd
reviewed
Jan 25, 2023
chudur-budur
force-pushed
the
github-871
branch
from
719536a to
112954b
Compare
diptorupd
reviewed
Jan 26, 2023
diptorupd
reviewed
Jan 26, 2023
chudur-budur
force-pushed
the
github-871
branch
2 times, most recently
from
6ee40f8 to
f536bd1
Compare
Better deprecation warnings added Following exact sycl::range/nd_range specification for kernel lauch parameters Default cache size is set to 128, like numba We don't need simplefilter
chudur-budur
force-pushed
the
github-871
branch
from
f536bd1 to
64b81a9
Compare
diptorupd
reviewed
Jan 29, 2023
diptorupd
changed the title
chudur-budur
force-pushed
the
github-871
branch
from
33f524f to
0018225
Compare
chudur-budur
force-pushed
the
github-871
branch
from
0018225 to
57c7d10
Compare
diptorupd
approved these changes
Jan 31, 2023
github-actions bot
added a commit
that referenced
this pull request
Jan 31, 2023
A more consistent kernel launch parameter syntax aa4eb5b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issues #867 and #871. This might also fix issue #886
Also related to issues #790 and #766