Use NumPy as python sublibrary in cmake #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it passes on all CI and on jenkins, it's good to go. |
chudur-budur
approved these changes
Dec 7, 2023
ZzEeKkAa
force-pushed
the
feature/use_numpy_as_python_sublibrary_in_cmake
branch
from
bef2ba9 to
50b8a46
Compare
github-actions bot
added a commit
that referenced
this pull request
Dec 7, 2023
…_sublibrary_in_cmake Use NumPy as python sublibrary in cmake f1be213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link numpy libraries as python submodule instead of linking it as a standalone package. This the second and the last PR to enable VSCode cpp integration via CMake toolset plugin. First one (IntelPython/dpctl#1484)
Old way of integration seems to be outdated and for some strange reason was not working in vscode.