Skip to content

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests using oneMKL LAPACK gesv instead of getrf and getrs in dpnp.linalg.solve() since the issues in oneMKL have been resolved. This removes the workaround implemented in #1763

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

Copy link
Contributor

github-actions bot commented Aug 14, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

github-actions bot commented Aug 14, 2025

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_26 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@vlad-perevezentsev vlad-perevezentsev self-assigned this Aug 18, 2025
@coveralls
Copy link
Collaborator

coveralls commented Aug 19, 2025

Coverage Status

coverage: 71.848% (-0.3%) from 72.19%
when pulling 9a0daa0 on use_gesv_solve
into 8133c3c on master.

@vlad-perevezentsev
Copy link
Collaborator Author

Coverage decrease is expected.
getrs function will be used in the future implementation of dpnp.linalg.lu_solve

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be having stability issues on Level Zero, internal CI shows it in TestSolve

@vlad-perevezentsev can you investigate if this is acceptable level of error and loosen the test if it is, and otherwise, look at it?

@vlad-perevezentsev
Copy link
Collaborator Author

@ndgrigorian Thank you for noticing this!
This is a typical mistake in tests on machines that do not support 64-bit floating point operations.
It is more correct to use assert_dtype_allclose there.
I have fixed that.

ndgrigorian
ndgrigorian previously approved these changes Aug 22, 2025
@antonwolfy antonwolfy added this to the 0.19.0 release milestone Sep 1, 2025
antonwolfy
antonwolfy previously approved these changes Sep 1, 2025
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Few minor nits below.

@vlad-perevezentsev vlad-perevezentsev merged commit 6d339e9 into master Sep 4, 2025
68 of 74 checks passed
@vlad-perevezentsev vlad-perevezentsev deleted the use_gesv_solve branch September 4, 2025 14:08
github-actions bot added a commit that referenced this pull request Sep 4, 2025
This PR suggests using oneMKL LAPACK `gesv` instead of `getrf` and
`getrs` in `dpnp.linalg.solve()` since the issues in oneMKL have been
resolved. This removes the workaround implemented in #1763 6d339e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants