Skip to content

Always return a real dtype from dpnp.linalg.cond #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 5, 2025

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 31, 2025

The PR updates dpnp.linalg.cond implementation to always return an array of real dtype, because the condition number can't be complex.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.19.0 release milestone Jul 31, 2025
@antonwolfy antonwolfy self-assigned this Jul 31, 2025
Copy link
Contributor

github-actions bot commented Jul 31, 2025

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

github-actions bot commented Jul 31, 2025

Array API standard conformance tests for dpnp=0.19.0dev3=py313h509198e_8 ran successfully.
Passed: 1227
Failed: 0
Skipped: 9

@coveralls
Copy link
Collaborator

coveralls commented Jul 31, 2025

Coverage Status

coverage: 72.108%. remained the same
when pulling f69b9d5 on correct-linalg-cond-dtype
into 54ee640 on master.

@antonwolfy antonwolfy marked this pull request as ready for review August 4, 2025 13:25
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy force-pushed the correct-linalg-cond-dtype branch from dd157a9 to dc66df6 Compare August 5, 2025 08:30
@antonwolfy antonwolfy force-pushed the correct-linalg-cond-dtype branch from dc66df6 to f69b9d5 Compare August 5, 2025 09:16
@antonwolfy antonwolfy merged commit c050de3 into master Aug 5, 2025
89 of 98 checks passed
@antonwolfy antonwolfy deleted the correct-linalg-cond-dtype branch August 5, 2025 14:36
github-actions bot added a commit that referenced this pull request Aug 5, 2025
The PR updates `dpnp.linalg.cond` implementation to always return an
array of real dtype, because the condition number can't be complex. c050de3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants