Disallow minlength=None in dpnp.bincount
#2310
Merged
+74
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.17.0dev6=py312he4f9c94_20 ran successfully. |
vtavana
approved these changes
Feb 12, 2025
Contributor
vtavana
left a comment
vtavana
left a comment
There was a problem hiding this comment.
Thank you, @antonwolfy!
Approved however there are failed tests in Array API that are not related to this PR (relates to dpnp.linalg.qr).
Contributor
Author
I filed #2311 to investigate that. |
Contributor
Author
|
@AlexanderKalistratov, could you please review also? |
AlexanderKalistratov
approved these changes
Feb 13, 2025
Collaborator
github-actions bot
added a commit
that referenced
this pull request
Feb 14, 2025
`minlength=None` was deprecated for `numpy.bincount` since numpy `1.14` and numpy is going to raise `TypeError` exception in `2.3.0` release. The PR propose to update implementation of `dpnp.bincount` and to disallow `minlength=None` in the same way as it will be implemented in NumPy 2.3.0. Additionally there is explicit type check of input arrays added through `dpnp.check_supported_arrays_type` calls at validation step. 131e4e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minlength=Nonewas deprecated fornumpy.bincountsince numpy1.14and numpy is going to raiseTypeErrorexception in2.3.0release.The PR propose to update implementation of
dpnp.bincountand to disallowminlength=Nonein the same way as it will be implemented in NumPy 2.3.0.Additionally there is explicit type check of input arrays added through
dpnp.check_supported_arrays_typecalls at validation step.