Skip to content

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Aug 1, 2024

In this PR, dpnp.fft.fft2, dpnp.fft.ifft2, dpnp.fft.fftn, dpnp.fft.ifftn are implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy previously approved these changes Aug 8, 2024
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more comments from me, thank you @vtavana

@vtavana vtavana requested a review from antonwolfy August 9, 2024 19:41
@vtavana vtavana dismissed antonwolfy’s stale review August 9, 2024 19:42

new changes were added

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana , LGTM
I have only one minor comment/question.

@vtavana vtavana merged commit 4b3b324 into master Aug 12, 2024
@vtavana vtavana deleted the fftn branch August 12, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants