Skip to content

Implement dpnp.logaddexp2 function #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antonwolfy merged 5 commits into from
Jul 31, 2024
Merged

Implement dpnp.logaddexp2 function #1955

antonwolfy merged 5 commits into from
Jul 31, 2024

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 30, 2024 •
edited
Loading

The PR adds implementation of dpnp.logaddexp2 function.
New binary universal function _logaddexp2 as added to _ufunc_impl pybind11 extension.

The all affected tests are updated to cover different use cases.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review July 30, 2024 15:35
vtavana
vtavana reviewed Jul 30, 2024
View reviewed changes
vtavana
vtavana approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit c94f9f8 into master Jul 31, 2024
@antonwolfy antonwolfy deleted the impl-logaddexp2 branch July 31, 2024 09:42
github-actions bot added a commit that referenced this pull request Jul 31, 2024
@github-actions
Implement dpnp.logaddexp2 function (#1955)
3981486 
* Add implementation of dpnp.logaddexp2

* Update third party tests

* Add more tests

* Update description based on review comments

* Add missing space in docstring c94f9f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

1 more reviewer

@vtavana vtavana vtavana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonwolfy @vtavana