Update dpnp.take implementation to get rid of limitations for input arguments
#1909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
npolina4
approved these changes
Jul 9, 2024
vtavana
reviewed
Jul 9, 2024
Co-authored-by: vtavana <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Jul 10, 2024
… arguments (#1909) * Remove limitations from dpnp.take implementation * Add more test to cover specail cases and increase code coverage * Applied pre-commit hook * Corrected test_over_index * Update docsctrings with resolving typos * Use dpnp.reshape() to change shape and create dpnp array from usm_ndarray result * Remove data syncronization from dpnp.get_result_array() * Update dpnp/dpnp_iface_indexing.py Co-authored-by: vtavana <[email protected]> * Applied review comments --------- Co-authored-by: vtavana <[email protected]> ce26cf0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to extend implementation of
dpnp.takeand to align the behavior with NumPy.Docstrings are updated with missing information about input arguments.
The tests are updated to cover more use cases and to include compute follows data scenario.