Replaced windows-latest with windows-2019 to fix windows builds #1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vlad-perevezentsev
approved these changes
May 17, 2024
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
Thanks @antonwolfy for experimenting and finding a working image!
6 tasks
antonwolfy
added a commit
that referenced
this pull request
Jun 3, 2025
The PR is indented to remove a temporary pinning to "windows-2019" and to revert changes from #1833. Besides Windows 2019 GitHub image is going to be fully unsupported by June 30, 2025. The impacted workflows are moved to use "windows-2022" GH runners. It requires updating `conda_build_config.yaml` where the version of the compiler as well as standard libraries have to be specified. While `{{ stdlib('c') }}` is installing into build environment as an alignment with recipe's meta yaml from conda-forge (see [dpctl#1868](IntelPython/dpctl#1868) as for reference).
github-actions bot
added a commit
that referenced
this pull request
Jun 3, 2025
The PR is indented to remove a temporary pinning to "windows-2019" and to revert changes from #1833. Besides Windows 2019 GitHub image is going to be fully unsupported by June 30, 2025. The impacted workflows are moved to use "windows-2022" GH runners. It requires updating `conda_build_config.yaml` where the version of the compiler as well as standard libraries have to be specified. While `{{ stdlib('c') }}` is installing into build environment as an alignment with recipe's meta yaml from conda-forge (see [dpctl#1868](IntelPython/dpctl#1868) as for reference). a4aa964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on experimentation, switching from using
"windows-latest"image to"windows-2019"fixes MS compiler use for Python packages.The PR implements the proposed temporary pinning to
"windows-2019".