Skip to content

update tests affected by changing TypeError to ValueError in dpctl #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2024
Merged

update tests affected by changing TypeError to ValueError in dpctl #1662

merged 3 commits into from
Jan 19, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jan 19, 2024 •
edited
Loading

In this PR, elementwise tests are updated to align with recent changes in dpctl gh-1496.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jan 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 19, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana
update tests
d33ce7d 
update more tests

rename varibale

update test hypot
@vtavana vtavana marked this pull request as ready for review January 19, 2024 16:51
antonwolfy
antonwolfy approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vtavana

@antonwolfy antonwolfy merged commit 0a5a2bd into master Jan 19, 2024
@antonwolfy antonwolfy deleted the update_tests branch January 19, 2024 23:36
@antonwolfy antonwolfy mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy