-
Notifications
You must be signed in to change notification settings - Fork 21
Add dpnp.linalg.solve() function #1598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Dec 5, 2023
antonwolfy
reviewed
Dec 7, 2023
antonwolfy
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a minor comment only, which can be addressed later.
Overall LGTM! Thank you @vlad-perevezentsev
eff8a79
to
c105570
Compare
github-actions bot
added a commit
that referenced
this pull request
Dec 13, 2023
* Add dpnp.linalg.solve() function * Add cupy tests for dpnp.linalg.solve() * Register a LinAlgError in dpnp.linalg submodule * Implementation of dtype dispatching with _common_type for dpnp.linalg.solve * Add a common_helpers.hpp file * Add validation functions for array types and dimensions for linalg funcs * Skip test_solve_singular_empty --------- Co-authored-by: Anton <[email protected]> 74609d6
github-actions bot
added a commit
to antonwolfy/dpnp
that referenced
this pull request
Dec 15, 2023
* Add dpnp.linalg.solve() function * Add cupy tests for dpnp.linalg.solve() * Register a LinAlgError in dpnp.linalg submodule * Implementation of dtype dispatching with _common_type for dpnp.linalg.solve * Add a common_helpers.hpp file * Add validation functions for array types and dimensions for linalg funcs * Skip test_solve_singular_empty --------- Co-authored-by: Anton <[email protected]> 74609d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing
dpnp.linalg.solve()
function to calculate the solution to the system of linear equations with a square coefficient matrix A and multiple right-hand sides usingoneapi::mkl::lapack::gesv
The implementation is written as a pybind11 extension above required LAPACK functions.