Skip to content

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Aug 24, 2023

In this PR, we implement dpnp.signbit and dpnp.proj using their counterpart in dpctl, i.e., dpctl.tensor.signbit and dpctl.tensor.proj.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana force-pushed the implement_signbit_proj branch from 0abd5e4 to 884aa03 Compare August 24, 2023 19:45
@vtavana vtavana force-pushed the implement_signbit_proj branch from 884aa03 to 1986a3b Compare August 25, 2023 14:10
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @vtavana

@antonwolfy antonwolfy merged commit 7cb1fd7 into master Aug 27, 2023
@antonwolfy antonwolfy deleted the implement_signbit_proj branch August 27, 2023 10:24
@antonwolfy antonwolfy mentioned this pull request May 31, 2024
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants