Skip to content

create_Unary_BinaryElementwisefunc_during_module_import #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 16, 2023

In this PR, we create Unary/BinaryElementwisefunc during module import in dpnp/dpnp_algo/dpnp_elementwise_common.py.

In addition, we modify the implementation of dpnp.add, dpnp.multiply, and dpnp.subtract. These functions now invoke oneapi::mkl::vm::add, oneapi::mkl::vm::multiply, and oneapi::mkl::vm::subtract from pybind11 extension of OneMKL VM, respectivelt, if possible or uses dpctl.tensor implementation if not.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 16, 2023
@vtavana vtavana force-pushed the create_Unary_BinaryElementwisefunc_during_module_import branch 4 times, most recently from 2c76440 to 2629f6b Compare August 16, 2023 17:21
@vtavana vtavana marked this pull request as ready for review August 16, 2023 17:22
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana force-pushed the create_Unary_BinaryElementwisefunc_during_module_import branch from 2629f6b to b4aa012 Compare August 18, 2023 17:03
@vtavana vtavana force-pushed the create_Unary_BinaryElementwisefunc_during_module_import branch 2 times, most recently from 5f27ee8 to 2753e37 Compare August 18, 2023 17:57
@vtavana vtavana force-pushed the create_Unary_BinaryElementwisefunc_during_module_import branch from 2753e37 to 24116e1 Compare August 18, 2023 18:01
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for aligning all the elementwise functions, @vtavana. LGTM!

@vtavana vtavana merged commit 36f26aa into master Aug 18, 2023
@vtavana vtavana deleted the create_Unary_BinaryElementwisefunc_during_module_import branch August 18, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants