Skip to content

Commit 5f27ee8

Browse files
vtavanavtavana
committed
address comments
1 parent afb84af commit 5f27ee8

File tree

2 files changed

+155
-163
lines changed

2 files changed

+155
-163
lines changed

‎dpnp/backend/extensions/vm/types_matrix.hpp

+62-62
Original file line numberDiff line numberDiff line change
@@ -68,31 +68,6 @@ struct AddOutputType
6868
dpctl_td_ns::DefaultResultEntry<void>>::result_type;
6969
};
7070

71-
/**
72-
* @brief A factory to define pairs of supported types for which
73-
* MKL VM library provides support in oneapi::mkl::vm::div<T> function.
74-
*
75-
* @tparam T Type of input vectors `a` and `b` and of result vector `y`.
76-
*/
77-
template <typename T>
78-
struct DivOutputType
79-
{
80-
using value_type = typename std::disjunction<
81-
dpctl_td_ns::BinaryTypeMapResultEntry<T,
82-
std::complex<double>,
83-
T,
84-
std::complex<double>,
85-
std::complex<double>>,
86-
dpctl_td_ns::BinaryTypeMapResultEntry<T,
87-
std::complex<float>,
88-
T,
89-
std::complex<float>,
90-
std::complex<float>>,
91-
dpctl_td_ns::BinaryTypeMapResultEntry<T, double, T, double, double>,
92-
dpctl_td_ns::BinaryTypeMapResultEntry<T, float, T, float, float>,
93-
dpctl_td_ns::DefaultResultEntry<void>>::result_type;
94-
};
95-
9671
/**
9772
* @brief A factory to define pairs of supported types for which
9873
* MKL VM library provides support in oneapi::mkl::vm::ceil<T> function.
@@ -109,38 +84,32 @@ struct CeilOutputType
10984
};
11085

11186
/**
112-
* @brief A factory to define pairs of supported types for which
113-
* MKL VM library provides support in oneapi::mkl::vm::mul<T> function.
87+
* @brief A factory to define pairs of supported types for which
88+
* MKL VM library provides support in oneapi::mkl::vm::cos<T> function.
11489
*
115-
* @tparam T Type of input vectors `a` and `b` and of result vector `y`.
90+
* @tparam T Type of input vector `a` and of result vector `y`.
11691
*/
11792
template <typename T>
118-
struct MulOutputType
93+
struct CosOutputType
11994
{
12095
using value_type = typename std::disjunction<
121-
dpctl_td_ns::BinaryTypeMapResultEntry<T,
122-
std::complex<double>,
123-
T,
124-
std::complex<double>,
125-
std::complex<double>>,
126-
dpctl_td_ns::BinaryTypeMapResultEntry<T,
127-
std::complex<float>,
128-
T,
129-
std::complex<float>,
130-
std::complex<float>>,
131-
dpctl_td_ns::BinaryTypeMapResultEntry<T, double, T, double, double>,
132-
dpctl_td_ns::BinaryTypeMapResultEntry<T, float, T, float, float>,
96+
dpctl_td_ns::
97+
TypeMapResultEntry<T, std::complex<double>, std::complex<double>>,
98+
dpctl_td_ns::
99+
TypeMapResultEntry<T, std::complex<float>, std::complex<float>>,
100+
dpctl_td_ns::TypeMapResultEntry<T, double, double>,
101+
dpctl_td_ns::TypeMapResultEntry<T, float, float>,
133102
dpctl_td_ns::DefaultResultEntry<void>>::result_type;
134103
};
135104

136105
/**
137106
* @brief A factory to define pairs of supported types for which
138-
* MKL VM library provides support in oneapi::mkl::vm::sub<T> function.
107+
* MKL VM library provides support in oneapi::mkl::vm::div<T> function.
139108
*
140109
* @tparam T Type of input vectors `a` and `b` and of result vector `y`.
141110
*/
142111
template <typename T>
143-
struct SubOutputType
112+
struct DivOutputType
144113
{
145114
using value_type = typename std::disjunction<
146115
dpctl_td_ns::BinaryTypeMapResultEntry<T,
@@ -160,54 +129,60 @@ struct SubOutputType
160129

161130
/**
162131
* @brief A factory to define pairs of supported types for which
163-
* MKL VM library provides support in oneapi::mkl::vm::cos<T> function.
132+
* MKL VM library provides support in oneapi::mkl::vm::floor<T> function.
164133
*
165134
* @tparam T Type of input vector `a` and of result vector `y`.
166135
*/
167136
template <typename T>
168-
struct CosOutputType
137+
struct FloorOutputType
169138
{
170139
using value_type = typename std::disjunction<
171-
dpctl_td_ns::
172-
TypeMapResultEntry<T, std::complex<double>, std::complex<double>>,
173-
dpctl_td_ns::
174-
TypeMapResultEntry<T, std::complex<float>, std::complex<float>>,
175140
dpctl_td_ns::TypeMapResultEntry<T, double, double>,
176141
dpctl_td_ns::TypeMapResultEntry<T, float, float>,
177142
dpctl_td_ns::DefaultResultEntry<void>>::result_type;
178143
};
179144

180145
/**
181-
* @brief A factory to define pairs of supported types for which
182-
* MKL VM library provides support in oneapi::mkl::vm::floor<T> function.
146+
* @brief A factory to define pairs of supported types for which
147+
* MKL VM library provides support in oneapi::mkl::vm::mul<T> function.
183148
*
184149
* @tparam T Type of input vector `a` and of result vector `y`.
185150
*/
186151
template <typename T>
187-
struct FloorOutputType
152+
struct LnOutputType
188153
{
189154
using value_type = typename std::disjunction<
155+
dpctl_td_ns::
156+
TypeMapResultEntry<T, std::complex<double>, std::complex<double>>,
157+
dpctl_td_ns::
158+
TypeMapResultEntry<T, std::complex<float>, std::complex<float>>,
190159
dpctl_td_ns::TypeMapResultEntry<T, double, double>,
191160
dpctl_td_ns::TypeMapResultEntry<T, float, float>,
192161
dpctl_td_ns::DefaultResultEntry<void>>::result_type;
193162
};
194163

195164
/**
196165
* @brief A factory to define pairs of supported types for which
197-
* MKL VM library provides support in oneapi::mkl::vm::ln<T> function.
166+
* MKL VM library provides support in oneapi::mkl::vm::mul<T> function.
198167
*
199-
* @tparam T Type of input vector `a` and of result vector `y`.
168+
* @tparam T Type of input vectors `a` and `b` and of result vector `y`.
200169
*/
201170
template <typename T>
202-
struct LnOutputType
171+
struct MulOutputType
203172
{
204173
using value_type = typename std::disjunction<
205-
dpctl_td_ns::
206-
TypeMapResultEntry<T, std::complex<double>, std::complex<double>>,
207-
dpctl_td_ns::
208-
TypeMapResultEntry<T, std::complex<float>, std::complex<float>>,
209-
dpctl_td_ns::TypeMapResultEntry<T, double, double>,
210-
dpctl_td_ns::TypeMapResultEntry<T, float, float>,
174+
dpctl_td_ns::BinaryTypeMapResultEntry<T,
175+
std::complex<double>,
176+
T,
177+
std::complex<double>,
178+
std::complex<double>>,
179+
dpctl_td_ns::BinaryTypeMapResultEntry<T,
180+
std::complex<float>,
181+
T,
182+
std::complex<float>,
183+
std::complex<float>>,
184+
dpctl_td_ns::BinaryTypeMapResultEntry<T, double, T, double, double>,
185+
dpctl_td_ns::BinaryTypeMapResultEntry<T, float, T, float, float>,
211186
dpctl_td_ns::DefaultResultEntry<void>>::result_type;
212187
};
213188

@@ -232,7 +207,7 @@ struct SinOutputType
232207

233208
/**
234209
* @brief A factory to define pairs of supported types for which
235-
* MKL VM library provides support in oneapi::mkl::vm::sqr<T> function.
210+
* MKL VM library provides support in oneapi::mkl::vm::ln<T> function.
236211
*
237212
* @tparam T Type of input vector `a` and of result vector `y`.
238213
*/
@@ -264,6 +239,31 @@ struct SqrtOutputType
264239
dpctl_td_ns::DefaultResultEntry<void>>::result_type;
265240
};
266241

242+
/**
243+
* @brief A factory to define pairs of supported types for which
244+
* MKL VM library provides support in oneapi::mkl::vm::sub<T> function.
245+
*
246+
* @tparam T Type of input vectors `a` and `b` and of result vector `y`.
247+
*/
248+
template <typename T>
249+
struct SubOutputType
250+
{
251+
using value_type = typename std::disjunction<
252+
dpctl_td_ns::BinaryTypeMapResultEntry<T,
253+
std::complex<double>,
254+
T,
255+
std::complex<double>,
256+
std::complex<double>>,
257+
dpctl_td_ns::BinaryTypeMapResultEntry<T,
258+
std::complex<float>,
259+
T,
260+
std::complex<float>,
261+
std::complex<float>>,
262+
dpctl_td_ns::BinaryTypeMapResultEntry<T, double, T, double, double>,
263+
dpctl_td_ns::BinaryTypeMapResultEntry<T, float, T, float, float>,
264+
dpctl_td_ns::DefaultResultEntry<void>>::result_type;
265+
};
266+
267267
/**
268268
* @brief A factory to define pairs of supported types for which
269269
* MKL VM library provides support in oneapi::mkl::vm::trunc<T> function.

0 commit comments

Comments
 (0)