Skip to content

Reorder checks in build docs action #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Reorder checks in build docs action #1506

merged 3 commits into from
Aug 2, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 1, 2023

The PR corrects checks order in build sphinx actions, because the check if a commit relates to pull request needs to be done before check about pull request relation to fork repository (since the fork flag is part of pull request context).

Additionally PR proposes to dump GitHub context, since it might be useful in future investigation in case of issue with the action.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy changed the title Enable publishing pull-request docs Reorder checks in build docs action Aug 1, 2023
@antonwolfy antonwolfy marked this pull request as ready for review August 1, 2023 20:22
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @antonwolfy !

@antonwolfy antonwolfy merged commit c333172 into master Aug 2, 2023
@antonwolfy antonwolfy deleted the publish_docs branch August 2, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants