Map dtype to device in array creation functions #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
force-pushed
the
map_dtype_to_device
branch
from
0c67adc to
b613816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to implement a dependency of default data type in creation functions on what is supported by target device.
The device may not support any of types:
dpnp.float16,dpnp.float64ordpnp.complex64. Thusdpnphas to consider that when it's requested to create an array with default data type. The type should be selected only among supported ones by the device.If a data type is passed explicitly in array creation function but the selected device doesn't support the type, an exception will be raise by
dpnpindicating the issue.