-
Notifications
You must be signed in to change notification settings - Fork 31
Add get_devices method to dpctl.SyclPlatform class
#1992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@oleksandr-pavlyk It occurred to me that |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl= ran successfully. |
d0d61c3 to
0629e08
Compare
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_521 ran successfully. |
1 similar comment
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_521 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_523 ran successfully. |
|
@oleksandr-pavlyk Using these device types would yield the same result as will always show 1. Same if To spare user confusion, I think it makes more sense to return empty lists for |
c5373d8 to
f60d32a
Compare
f60d32a to
1c8ee57
Compare
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_541 ran successfully. |
1c8ee57 to
6332448
Compare
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_11 ran successfully. |
antonwolfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndgrigorian, I have a minor comment, but in overall LGTM
Also removes some remaining, sporadic references to the deprecated sycl::info::device_type::host
These device types act unexpectedly in DPC++ 2025.0.4, returning the same result as `sycl::info::device_type::all`, so use unknown device and return an empty list instead
This comment describes why automatic and custom device type are handled as unknown
6332448 to
c99d791
Compare
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_22 ran successfully. |
Added optional back to `dpctl.SyclPlatform.get_devices` device_type argument Made typing of arguments explicit in `dpctl.get_num_devices` and `dpctl.get_devices`
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_23 ran successfully. |
antonwolfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more comments from me. Thank you @ndgrigorian
This PR proposes implementing the
get_devicesmethod todpctl.SyclPlatformclass as per SYCL 2020 spec, which specifies including adevice_typefilter.Cleans up some remaining references to host devices, missed in #1028
Closes #509