Skip to content

Fix dpctl.tensor.isdtype function signature #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

ndgrigorian
Copy link
Collaborator

This pull request moves isdtype to _type_utils.py to make the function signature match what is required by the array API specification.

Additionally experiments with using the --disable-deadline when running array API tests, as some tests fail for exceeding the deadline.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

Copy link

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_20 ran successfully.
Passed: 907
Failed: 2
Skipped: 86

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 90.684%. remained the same
when pulling 7a1bef7 on aa-conformity-chores
into 3277028 on master.

Copy link

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_23 ran successfully.
Passed: 909
Failed: 0
Skipped: 86

@ndgrigorian ndgrigorian marked this pull request as ready for review January 24, 2024 03:17
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian

@oleksandr-pavlyk oleksandr-pavlyk merged commit 12cd523 into master Jan 24, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the aa-conformity-chores branch January 24, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants