Skip to content

Fix for complex sorting test failure #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Jan 19, 2024

test_sort_1d[c16] and test_sort_2d[c16] were failing on GPU devices supporting double precision,

This PR applies a work-around by using std::isnan until the bug is analyzed and fixed. Both failing tests pass now.

Additionally, this PR replaced use of while loop in sort_over_work_group_contig_krn with use of for loop over fixed size interval reducing branching/

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Sorting test were failing for complex128 types on capable Intel GPU
devices. Change from sycl::isnan to std::isnan fixes these failures.
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 90.187%. remained the same
when pulling af3ed63 on fix-for-complex-sorting-test-failure
into 2cb368c on master.

Copy link

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_12 ran successfully.
Passed: 897
Failed: 12
Skipped: 86

@oleksandr-pavlyk oleksandr-pavlyk merged commit 9a80b47 into master Jan 22, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-for-complex-sorting-test-failure branch January 22, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants