Skip to content

Modified gen_coverage to also collect data from Pybind11 modules #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 13, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

This will provide coverage for the host portion of offloading Pybind11 extensions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

@coveralls
Copy link
Collaborator

coveralls commented Nov 24, 2023

Coverage Status

coverage: 89.644% (+3.6%) from 85.998%
when pulling 644eadc on coverage-for-pybind11-extensions
into 46583b8 on master.

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_18 ran successfully.
Passed: 1018
Failed: 56
Skipped: 59

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_19 ran successfully.
Passed: 1018
Failed: 56
Skipped: 59

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review November 25, 2023 03:39
Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_20 ran successfully.
Passed: 1019
Failed: 55
Skipped: 59

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_38 ran successfully.
Passed: 877
Failed: 55
Skipped: 59

Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_39 ran successfully.
Passed: 879
Failed: 53
Skipped: 59

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the coverage-for-pybind11-extensions branch from aafe056 to 644eadc Compare December 12, 2023 03:51
Copy link

Array API standard conformance tests for dpctl=0.15.1dev2=py310h15de555_42 ran successfully.
Passed: 877
Failed: 55
Skipped: 59

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to see the coverage so high, thank you @oleksandr-pavlyk

@oleksandr-pavlyk oleksandr-pavlyk merged commit b29a9d7 into master Dec 13, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the coverage-for-pybind11-extensions branch December 13, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants