Skip to content

Implements dpctl.tensor.clip #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 25, 2023
Merged

Implements dpctl.tensor.clip #1444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aef53f9
Implements dpctl.tensor.clip
ndgrigorian Oct 17, 2023
fb7887c
Clip now consistently yields max where max < min
ndgrigorian Oct 20, 2023
6277756
Adds more tests for clip
ndgrigorian Oct 20, 2023
87f5775
Removed redundant branches in clip and elementwise function calls
ndgrigorian Oct 21, 2023
2d0182b
Removed more redundant logic from clip
ndgrigorian Oct 21, 2023
89fbdc1
Fixed order logic in clip
ndgrigorian Oct 21, 2023
f1ac569
Adds more compute follows data tests for clip
ndgrigorian Oct 21, 2023
f856624
Tests to increase coverage of _clip.py (#1451)
oleksandr-pavlyk Oct 23, 2023
d839124
Clip raises ValueError when types cannot be resolved
ndgrigorian Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dpctl/tensor/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ set(_tensor_impl_sources
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/elementwise_functions.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/repeat.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/reduction_over_axis.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/clip.cpp
)

set(python_module_name _tensor_impl)
Expand All @@ -65,6 +66,7 @@ set(_no_fast_math_sources
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/linear_sequences.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/elementwise_functions.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/reduction_over_axis.cpp
${CMAKE_CURRENT_SOURCE_DIR}/libtensor/source/clip.cpp
)
foreach(_src_fn ${_no_fast_math_sources})
get_source_file_property(_cmpl_options_prop ${_src_fn} COMPILE_OPTIONS)
Expand Down
2 changes: 2 additions & 0 deletions dpctl/tensor/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
from dpctl.tensor._usmarray import usm_ndarray
from dpctl.tensor._utility_functions import all, any

from ._clip import clip
from ._constants import e, inf, nan, newaxis, pi
from ._elementwise_funcs import (
abs,
Expand Down Expand Up @@ -322,4 +323,5 @@
"exp2",
"copysign",
"rsqrt",
"clip",
]
Loading