Skip to content

Avoid needless copies #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Avoid needless copies #1421

merged 9 commits into from
Sep 26, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR applies code changes to address Coverity's change COPY_INSTEAD_OF_MOVE issue. There are 10923 issues of type COPY_INSTEAD_OF_MOVE in main branch.

This branch reduces that number down to 8378. Remaining issues are outside of dpctl source base (mostly in DPC++ code).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 85.777% (+0.003%) from 85.774% when pulling 15f9320 on avoid-needless-copy into 8de5201 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.15.0rc2=py310ha25a700_21 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thank you @oleksandr-pavlyk

@oleksandr-pavlyk oleksandr-pavlyk merged commit 66b16ee into master Sep 26, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the avoid-needless-copy branch September 26, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants