Skip to content

Correct address_space when casting ref of local variable to multi_ptr #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

oleksandr-pavlyk
Copy link
Contributor

Used address_space_cast<address_space::private_space,...> on a local variable.

To create the sycl::multi_ptr from a local variable (in private memory) we should be using address_space::private_space.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

To create the multi_ptr from a local variable (in private memory) we should be
using address_space::private_space.
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_48 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit 87d1c13 into master Sep 6, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the correct-address-space-in-address-space-cast branch September 6, 2023 15:57
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants