Skip to content

[MOB-11441] Add CodePush Support #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 25 commits into from
Closed

[MOB-11441] Add CodePush Support #877

wants to merge 25 commits into from

Conversation

DavidMina96
Copy link
Contributor

@DavidMina96 DavidMina96 commented Jan 2, 2023 •
edited
Loading

Description of the change

  • Add codePushLabel property to InstabugConfig and its native mappings on both platforms, along with the needed tests.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@DavidMina96 DavidMina96 marked this pull request as ready for review January 2, 2023 12:32
@DavidMina96 DavidMina96 requested a review from a7medev January 2, 2023 12:32
@DavidMina96 DavidMina96 self-assigned this Jan 2, 2023
a7medev
a7medev reviewed Jan 3, 2023
View reviewed changes
@DavidMina96 DavidMina96 force-pushed the feature/set-code-push-version branch from 215a780 to e7fc704 Compare January 3, 2023 11:09
@DavidMina96 DavidMina96 requested a review from a7medev January 3, 2023 11:42
@DavidMina96 DavidMina96 force-pushed the feature/set-code-push-version branch from b84bf34 to 4021d6b Compare January 3, 2023 12:06
a7medev
a7medev previously approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@DavidMina96 DavidMina96 added pending-android Waiting for Android release pending-ios Waiting for iOS release labels Jan 3, 2023
Base automatically changed from dev to master February 20, 2023 14:52
@stale
Copy link

stale bot commented Feb 27, 2023

This issue has been automatically marked as pending feedback because we need additional information to be able to investigate it further. It will be closed in 7 days if it remains inactive. Thank you for your contributions.

a7medev and others added 3 commits March 2, 2023 10:38
@a7medev
[MOB-12033] Restructure native Directory (#933)
ec1f130 
* Restructure Native Directory

* Remove commented code

* Fix imports in mocks
@a7medev
[MOB-9962] Migrate to NativeEventEmitter (#924)
0f48f89 
* Migrate the current IBGEventEmitter which uses the old NativeAppEventEmitter and DeviceEventEmitter to the new NativeEventEmitter which requires each module to have its own event emitter so the way we use emitter got restructured.

* Eliminate NetworkLogger's event emitters usage by using callbacks.
@TheBuggedYRN
[MOB-12043] Remove Android Module Dead Code (#884)
102ddc3
@stale
Copy link

stale bot commented Mar 6, 2023

This issue has been automatically closed since we haven't heard back from you. Please feel free to re-open the issue if you have more information to add.

@stale stale bot closed this Mar 6, 2023
@DavidMina96 DavidMina96 reopened this Mar 7, 2023
@DavidMina96 DavidMina96 added WIP Work In Progress and removed Pending Feedback labels Mar 7, 2023
TheBuggedYRN and others added 9 commits March 8, 2023 12:16
@TheBuggedYRN
[MOB-11997] Replace CLI dir flag with file (#937)
752b924
@TheBuggedYRN
[MOB-12070] Disable Sorucemaps Scripts on CI (#940)
06d364c 
The upload scripts used to run while running both Unit and E2E CI jobs,
resulting in more redundant time or unintended behavior.

These scripts were disabled by:
 1. Android: passing the `instabugUploadEnable` gradle property.
 2. iOS: setting the `INSTABUG_SOURCEMAPS_UPLOAD_DISABLE` environment variable.
@DavidMina96
Run probot-stale only on issues (#941)
a282b40
@TheBuggedYRN
[MOB-12143] Use circleci/ruby Image for Danger (#944)
07309e4 
The old dantoml/danger:latest is updated 4 years ago,
which makes it an obsolete image that lacks a lot of version upgrades.
@TheBuggedYRN
[MOB-12052] Use Shallow Checkout in CI (#943)
0067537 
The checkout step used to take around a minute 
due to the size of the repo (1 GB). With shallow
checkouts, it gets down to one second.
@TheBuggedYRN
[MOB-12050] Cache CI Pods (#945)
007a3bb
@TheBuggedYRN
[MOB-12180] Remove Redundant CI Steps (#947)
d8003a8
@TheBuggedYRN
[MOB-12053] Use node CI Orb (#946)
cb0d389 
By using the node orb, we benefit from the following:
 1. Default machine executors.
 2. Caching node_modules.
@a7medev
[MOB-12204] Upgrade macOS Resource Class to Gen2
74ed172
TheBuggedYRN and others added 4 commits March 22, 2023 10:11
@TheBuggedYRN
[MOB-12207] Fix CLI Typos (#952)
b2d01a7
@DavidMina96
[MOB-12202] Create examples directory (#951)
c8acb16 
Rename the current example directory to default, move it to a new examples directory, and adjust the paths where needed.
@DavidMina96
Add codePushLabel to InstabugConfig and init
9f86df5
@DavidMina96
Add codePushLabel to init on Android
2fdbba4
@DavidMina96 DavidMina96 force-pushed the feature/set-code-push-version branch from 4021d6b to aae0e20 Compare March 22, 2023 13:53
@DavidMina96 DavidMina96 changed the base branch from master to dev March 22, 2023 13:54
@DavidMina96 DavidMina96 force-pushed the feature/set-code-push-version branch from aae0e20 to 077f2ec Compare March 22, 2023 14:09
@DavidMina96 DavidMina96 force-pushed the feature/set-code-push-version branch from cca3288 to 9f07c2f Compare March 22, 2023 16:30
@DavidMina96 DavidMina96 force-pushed the feature/set-code-push-version branch from 9f07c2f to bbb7a95 Compare March 23, 2023 09:07
@DavidMina96 DavidMina96 mentioned this pull request Mar 23, 2023
Draft
7 tasks
Base automatically changed from dev to master April 20, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev Awaiting requested review from a7medev

@TheBuggedYRN TheBuggedYRN Awaiting requested review from TheBuggedYRN

Assignees

@DavidMina96 DavidMina96

Labels
pending-android Waiting for Android release pending-ios Waiting for iOS release WIP Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidMina96 @a7medev @abdelhamid-f-nasser @TheBuggedYRN