Skip to content

[MOB-12053] Use node CI Orb #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2023
Merged

[MOB-12053] Use node CI Orb #946

merged 2 commits into from
Mar 20, 2023

Conversation

TheBuggedYRN
Copy link
Contributor

@TheBuggedYRN TheBuggedYRN commented Mar 15, 2023 •
edited
Loading

Description of the change

By using the node orb, we benefit from the following:

  1. Default machine executors.
  2. Caching node_modules.
Before After
before after

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@TheBuggedYRN TheBuggedYRN force-pushed the ci/cache-node-modules branch 9 times, most recently from da6ef81 to 3a62e6a Compare March 15, 2023 14:12
@TheBuggedYRN TheBuggedYRN changed the title [MOB-12053] Cache CI Node Modules [MOB-12053] Use node CI Orb Mar 15, 2023
@TheBuggedYRN TheBuggedYRN force-pushed the ci/cache-node-modules branch 2 times, most recently from 835f550 to acc697a Compare March 16, 2023 11:04
@TheBuggedYRN TheBuggedYRN self-assigned this Mar 16, 2023
@TheBuggedYRN TheBuggedYRN force-pushed the ci/cache-node-modules branch from acc697a to cd973e0 Compare March 16, 2023 11:10
@TheBuggedYRN TheBuggedYRN marked this pull request as ready for review March 16, 2023 11:32
a7medev
a7medev approved these changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏

@TheBuggedYRN TheBuggedYRN merged commit cb0d389 into dev Mar 20, 2023
@TheBuggedYRN TheBuggedYRN deleted the ci/cache-node-modules branch March 20, 2023 11:41
HeshamMegid pushed a commit that referenced this pull request Apr 20, 2023
@TheBuggedYRN @HeshamMegid
[MOB-12053] Use node CI Orb (#946)
9e76e3e 
By using the node orb, we benefit from the following:
 1. Default machine executors.
 2. Caching node_modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

@DavidMina96 DavidMina96 Awaiting requested review from DavidMina96

Assignees

@TheBuggedYRN TheBuggedYRN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBuggedYRN @a7medev