Remove backslash (+ indent) from string literals in tests #3717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Filtering
dzenanz
approved these changes
Nov 2, 2022
Contributor
Author
|
FYI, I did a separate commit for itkBSplineDecompositionImageFilterTest because it was slightly more complicated, and it could not be handled entirely by the regular expressions used for the first commit (which is the largest commit of the three). |
dzenanz
approved these changes
Nov 3, 2022
Contributor
Author
|
/azp run ITK.macOS |
Member
|
Thanks for doing this Niels. Rebasing on |
Removed unwanted (unintentional) spaces from test output messages, which were caused by an indentation after a backslash continuation character, inside a string literal. Using Notepad++ v8.4.5 Regular Expressions: - Find what: `^([^"\r\n]*"[^"\r\n]* )\\\r\n[ ]+` - Replace with: `$1` - Find what: `^([^"\r\n]*"[^"\r\n]*)\\\r\n[ ]+` - Replace with: `$1 ` Follow-up to pull request InsightSoftwareConsortium#3713 commit 69151c3 "STYLE: Remove backslash + indent from literals, to avoid unwanted spaces"
Small style improvement without runtime behavior change, as a follow-up to pull request InsightSoftwareConsortium#3713 commit d0abdff "STYLE: Remove backslash (continuation character) from string literals"
Removed unwanted (unintentional) spaces from the error message at the begin of itkBSplineDecompositionImageFilterTest. Follow-up to pull request InsightSoftwareConsortium#3713 commit 69151c3 "STYLE: Remove backslash + indent from literals, to avoid unwanted spaces"
N-Dekker
force-pushed
the
Remove-backslash-continuation-chars-from-inside-literal-strings-in-tests
branch
from
ce33d09 to
77cb3be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to pull request #3713 "Remove backslash (+ indent) from string literals", but now applied to tests (
itk*Test*.cxxfiles).Removes unwanted (unintentional) spaces from test output messages, which were caused by an indentation after a backslash continuation character.