Features/reusable workflows and doc #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Google auth file if the corresponding secret is set * Remove terraform plan from estimation job in check-secure-estimate workflow * Remove AWS-related auth env vars in check-secure-estimate workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the main PR workflow into several independant reusable workflows. Said reusable workflows may be copied in a independant repository to allow for parallel maintainance of several repositories' workflows.
In such a case, the new
on_pull_request.ymlworkflow should be updated to point toward the reference repository (private repositories will need specific configuration to enable sharing, see https://docs.github.com/en/actions/using-workflows/reusing-workflows#access-to-reusable-workflows )Also adds a job that ensures that the documentation is up-to-date. Part of the shell sheganigans occuring in the step
Prepare PR messageis due to the fact that the terraform-docs step adds updated files to staging even if it is not configured to commit them. The doc workflow call inon_pull_request.ymlmay also be set to commit documentation changes by setting thecommitinput totrue.Note that this PR also includes changes from #1