StringAlgoTest : Add more coverage for matchMultiple()
#1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f42605 fixed bugs and performance issues related to wildcards and space separated patterns. One bug that I don't think I realised I was fixing at the time was the matching of spaces in the string against spaces separating match patterns. This appears to have affected some production scenes which were relying on the broken behaviour. Having reviewed the code again, I'm pretty sure we are doing the right thing, so I'm just beefing up the tests a little to assert that and make sure we don't change behaviour again in future.
andrewkaufman
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0f42605 fixed bugs and performance issues related to wildcards and space separated patterns. One bug that I don't think I realised I was fixing at the time was the matching of spaces in the string against spaces separating match patterns. This appears to have affected some production scenes which were relying on the broken behaviour. Having reviewed the code again, I'm pretty sure we are doing the right thing, so I'm just beefing up the tests a little to assert that and make sure we don't change behaviour again in future.