Skip to content

Column pinning - both sides. #16132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Aug 21, 2025
Merged

Column pinning - both sides. #16132

merged 33 commits into from
Aug 21, 2025

Conversation

MayaKirova
Copy link
Contributor

@MayaKirova MayaKirova commented Aug 12, 2025 •
edited
Loading

Closes #16142
Spec is here

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MayaKirova MayaKirova marked this pull request as ready for review August 14, 2025 07:57
@MayaKirova MayaKirova requested a review from dkamburov August 14, 2025 07:57
@dkamburov dkamburov assigned tishko0 and unassigned MarielaTihova Aug 19, 2025
@tishko0 tishko0 added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Aug 20, 2025
dkamburov
dkamburov reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@dkamburov dkamburov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I left some small review comments

@MayaKirova MayaKirova requested a review from dkamburov August 20, 2025 15:43
@tishko0 tishko0 added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Aug 21, 2025
@ChronosSF
Copy link
Member

LGTM too

@ChronosSF ChronosSF merged commit 1b9d9e2 into master Aug 21, 2025
5 of 7 checks passed
@ChronosSF ChronosSF deleted the mkirova/col-pin-directions branch August 21, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkamburov dkamburov dkamburov approved these changes

Assignees

@dkamburov dkamburov

@tishko0 tishko0

Labels
grid: column-pinning version: 20.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column pinning - both sides
6 participants
@MayaKirova @ChronosSF @dkamburov @tishko0 @MarielaTihova @Lipata