fix(button): update styling sample Sass functions #3780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Sass styling sample for button components by replacing the deprecated button-theme function with more specific theme functions (contained-button-theme, outlined-button-theme, and flat-button-theme). The changes align with updated API design patterns that provide separate theming functions for different button variants.
Key Changes
- Replaced single
button-themefunction with variant-specific theme functions - Updated theme property names to match the new API (removed some border-related properties, added new focus/active properties)
- Added separate theme examples for contained, outlined, and flat button variants
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/app/data-entries/buttons/buttons-style/buttons-style.component.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6256